Fork me on GitHub

#1 2012-03-20 19:33:39

Sable
Member
From: France
Registered: 2012-02-20
Posts: 87

[FIXED] "Groups" Application opens "Home"

Hi,

in eyeApps, when we open the "Groups" application (eyeFiles), it opens the Home's folders/files, like with the "File manager" shortcut... Didn't you want it to open the Groups's folders?

Thank you.

Offline

#2 2012-03-20 23:53:00

s0600204
Member
From: UK
Registered: 2012-01-22
Posts: 118
Website

Re: [FIXED] "Groups" Application opens "Home"

Hi Sable,

I think I found the problem.

When eyeApps launches eyeGroups, eyeGroups then calls eyeFiles, handing it two parameters (interpreted by eyeFiles as 'path' and 'type' respectively). The first of these parameters happens to be the first parameter that eyeGroups itself receives (this would normally be the name of a group but eyeApps doesn't pass anything so it defaults to null), whilst the second is the instruction to look in the groups directory. Upon receiving the call, eyeFiles checks for a value in the first parameter and, finding it null, ignores the second parameter, defaulting to the user's home folder.

The solution is to check within eyeGroups whether or not a parameter has been given to eyeGroups and if not, supply one:

BEFORE:
function eyeGroups_run($params = '') {
	proc('launch',array('eyeFiles',array($params[0],'groups')));
	proc('end');
}

AFTER:
function eyeGroups_run($params = '') {
	if (!isset($params[0])) {
		$params[0] = '/';
	}
	proc('launch',array('eyeFiles',array($params[0],'groups')));
	proc('end');
}

commited r.7426

Last edited by s0600204 (2012-03-21 00:06:59)

Offline

#3 2012-03-21 00:57:32

lars-sh
Administrator
From: near Hamburg, Germany
Registered: 2011-07-14
Posts: 730
Website

Re: [FIXED] "Groups" Application opens "Home"

Thanks for reporting, thanks for fixing!


Best regards,
Lars Knickrehm

The oneye project.

Offline

#4 2012-03-21 20:00:55

Sable
Member
From: France
Registered: 2012-02-20
Posts: 87

Re: [FIXED] "Groups" Application opens "Home"

Great! It works fine, now smile

Thank you s0600204!

Offline

Board footer

Powered by FluxBB