Fork me on GitHub

#1 2012-06-12 23:46:38

shann
Member
From: France
Registered: 2012-04-06
Posts: 11

[FIXED] issue in newuser.eyecode (last svn 7569)

Hi,

I find issue in newuser.eyecode in (oneyexxx/apps/eyeControl/events/newuser.eyecode).
In fact i try to add a new user (simple user) and oneye popup appear with 'the user name contains invalid characters..'.

Once again, launch web developer tools in Firefox and see:

Notice: Undefined variable: user in /srv/http/oneye/oneyexxx/apps/eyeControl/events/newuser.eyecode on line 94
Notice: Undefined variable: user in /srv/http/oneye/oneyexxx/apps/eyeControl/events/newuser.eyecode on line 117

I check code and view:

Line 94:
if ($username && $password && $pwd_again && um('isValidUsername', array($user)) === true && !um('userExist',array($username)) && $password === $pwd_again && utf8_strlen($username) > 2 && utf8_strlen($username) <= MAX_USERNAME_LEN) {

Line 117:
} elseif (um('isValidUsername', array($user)) === false) {

I modified $user  in $username for fixed issues wink

Last edited by lars-sh (2012-06-13 17:44:56)

Offline

#2 2012-06-13 01:54:13

s0600204
Member
From: UK
Registered: 2012-01-22
Posts: 118
Website

Re: [FIXED] issue in newuser.eyecode (last svn 7569)

Thank you for reporting this bug.

Lars recently added a function to the um service to check whether a username is valid or not. This replaced multiple copies of needlessly repeated code that did the same thing. Evidently, something went awry in the process of Lars transferring the improvement into his working copy of the repository.

The fix has been committed to the repository (r.7571)

Offline

#3 2012-06-13 17:42:34

lars-sh
Administrator
From: near Hamburg, Germany
Registered: 2011-07-14
Posts: 731
Website

Re: [FIXED] issue in newuser.eyecode (last svn 7569)

Thanks both.

I just updated my working copy and went into conflicts at those two places. Seems as if it's a SVN problem while committing. Ugly.


Best regards,
Lars Knickrehm

The oneye project.

Offline

Board footer

Powered by FluxBB